Repository navigation
test(spanner): unflake InlineBeginTransactionTest - #14686
Open
sakthivelmanii wants to merge 2 commits into
Open
sakthivelmanii wants to merge 2 commits into
sakthivelmanii wants to merge 2 commits into
Conversation
In ResumableStreamIterator, when close() is called while startStream() is in flight, stream is null so cancellation is dropped and isWithBeginTransaction() evaluates to false, causing listener.onDone(false) and unhandled transactionIdFuture resolution on mock unfreeze. This fix cleanly checks closed state immediately after stream start under lock, invokes onStreamClosedWhileStarting to fail transactionIdFuture with CANCELLED without modifying StreamStarter signatures, and adds deterministic latch-based unit tests.
sakthivelmanii
enabled auto-merge (squash)
October 19, 2026 13:27
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a concurrency issue where a ResultSet is closed while its underlying stream is being started. It introduces synchronization and state tracking in ResumableStreamIterator to ensure that a concurrently started stream is properly closed and its BeginTransaction option is reported. A critical review comment identifies a potential bug where listener.onDone could be called twice concurrently (once with false and once with true), which may cause the transaction to hang or fail silently due to onDone being guarded by a compareAndSet check.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ResumableStreamIterator, when close() is called while startStream() is in flight, stream is null so cancellation is dropped and isWithBeginTransaction() evaluates to false, causing listener.onDone(false) and unhandled transactionIdFuture resolution on mock unfreeze. This fix cleanly checks closed state immediately after stream start under lock, invokes onStreamClosedWhileStarting to fail transactionIdFuture with CANCELLED without modifying StreamStarter signatures, and adds deterministic latch-based unit tests.