Skip to content

build(deps): pin native-maven-plugin and override download-maven-plugin plexus dependency for Airlock - #14754

Merged
blakeli0 merged 2 commits into
googleapis:mainfrom
hj690:fix-airlock-native-and-download-plugins
Oct 24, 2026
Merged

blakeli0 merged 2 commits into
googleapis:mainfrom
hj690:fix-airlock-native-and-download-plugins

Conversation

@hj690

@hj690 hj690 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR resolves the two remaining plugin dependency issues reported by the java-missing-airlock-deps audit (b/568717591):

  1. Pin org.graalvm.buildtools:native-maven-plugin to ${native-maven-plugin.version} (0.10.6):

    • java-shared-config/native-image-shared-config/pom.xml previously declared <version>${native-maven-plugin.version}</version> only inside <profile><id>native</id>.
    • Three modules (google-auth-library-java/credentials, google-auth-library-java/appengine, and java-spanner/google-cloud-spanner) configure native-maven-plugin in top-level <build><plugins> without <version>. When -Pnative is inactive, Maven resolves the latest version from maven-metadata.xml (1.1.16), which is still in Airlock's 14-day soak window.
    • Add native-maven-plugin to <build><pluginManagement><plugins> in native-image-shared-config/pom.xml and set <version>${native-maven-plugin.version}</version> in those three modules (matching grpc-gcp-java/pom.xml).
  2. Override org.codehaus.plexus:plexus-container-default to 1.0-alpha-9-stable-1 in download-maven-plugin:1.6.8:

    • com.googlecode.maven-download-plugin:download-maven-plugin:1.6.8 in java-showcase/gapic-showcase and sdk-platform-java/gapic-generator-java transitively pulls org.codehaus.plexus:plexus-container-default:1.0-alpha-8, which Airlock parks in standard-maven-3p-l1-limited-internal-use due to missing upstream license metadata.
    • Add a plugin <dependency> override pinning org.codehaus.plexus:plexus-container-default to 1.0-alpha-9-stable-1 (with *:* exclusions), which is available in maven-3p-trusted.

@hj690
hj690 requested review from a team as code owners October 23, 2026 15:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Maven configuration files across different modules. It explicitly sets the version ${native-maven-plugin.version} for the native-maven-plugin in multiple submodules and adds it to the plugin management of native-image-shared-config. Additionally, it adds a dependency on plexus-container-default with wildcard exclusions to the download-maven-plugin configuration in both gapic-showcase and gapic-generator-java. There are no review comments, so I have no feedback to provide.

…en showcase copies

Apply the same plexus-container-default 1.0-alpha-9-stable-1 override to
sdk-platform-java/java-showcase-3.21.0 and java-showcase-3.25.8. The
showcase.yaml workflow builds both copies with mvn verify, so they also
resolve plexus-container-default 1.0-alpha-8 through download-maven-plugin
1.6.8.
@blakeli0
blakeli0 merged commit 165f02e into googleapis:main Oct 24, 2026
486 of 489 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants