Repository navigation
fix: update swagger-ui to 5.29.1 and add SRI hashes - #1060
Merged
Merged
Conversation
This was referenced Sep 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1060 +/- ##
=======================================
Coverage 76.09% 76.09%
=======================================
Files 67 67
Lines 3619 3619
=======================================
Hits 2754 2754
Misses 654 654
Partials 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1053 (the SRI and version part; keeps the CDN as discussed there).
/docsfrom 4.15.5 to 5.29.1, the newest release on cdnjs. npm has 5.33.0, but cdnjs has not published it yet.integrity(sha512),crossorigin="anonymous"andreferrerpolicy="no-referrer"to the stylesheet and both scripts. cdnjs sendsAccess-Control-Allow-Origin: *, so the CORS-mode fetch SRI needs works.<script>/<link>in the page has no hash, so a later version bump can't drop it without anyone noticing.The hashes match three sources: the cdnjs API, a local
sha512of the served files, and theswagger-ui-dist@5.29.1npm tarball (byte-identical).Regression check. I ran master and this branch side by side and loaded
/docsin headless Chromium:GET /current/userswagger?base=The Swagger 2.0 spec renders unchanged. 5.x only adds an "OAS 2.0" badge next to the version.