Drop config Grails 8 now supplies itself - #26
Merged
Merged
Conversation
Grails 8 hard-codes the whole MIME table in MimeType.createDefaults() -- all, atom, css, csv, form, html, js, json, multipartForm, pdf, rss, text, hal and xml, plus application/vnd.api+json -- and merges anything a project declares in grails.mime.types over it, per grails.mime.mergeDefaults. The demo app's block restated those defaults verbatim, so removing it changes nothing. The two logback-spring.xml files go with it. Neither is published -- the plugin jar carries no logback resource -- so they only ever shaped local runs, and what they set up was Spring Boot's own defaults.xml plus a console appender, which Boot installs unprompted. The plugin's copy had also drifted: a duplicated ahr logger and an io.awspring.cloud one for a dependency this project does not have, left over from whatever skeleton it was copied from. One real change: the demo app pinned its root logger to ERROR, and now takes Boot's INFO default, so bootRun is more verbose than it was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grails 8 hard-codes the whole MIME table in
MimeType.createDefaults()—all,atom,css,csv,form,html,js,json,multipartForm,pdf,rss,text,halandxml, plusapplication/vnd.api+json— and merges anything a project declares ingrails.mime.typesover it, pergrails.mime.mergeDefaults. The demo app's block restated those defaults verbatim, so removing it changes nothing.The two
logback-spring.xmlfiles go with it. Neither is published — the plugin jar carries no logback resource — so they only ever shaped local runs, and what they set up was Spring Boot's owndefaults.xmlplus a console appender, which Boot installs unprompted. The plugin's copy had also drifted: a duplicatedahrlogger and anio.awspring.cloudone for a dependency this project does not have, left over from whatever skeleton it was copied from.One real change: the demo app pinned its root logger to
ERROR, and now takes Boot'sINFOdefault, sobootRunis more verbose than it was.