Skip to content

Remove graphql.operation type / name from spans where it shouldn't be available - #68

Merged
PascalSenn merged 1 commit into
graphql:mainfrom
tobias-tengler:tte/remove-unavailable-attributes
Mar 5, 2026
Merged

PascalSenn merged 1 commit into
graphql:mainfrom
tobias-tengler:tte/remove-unavailable-attributes

Conversation

@tobias-tengler

Copy link
Copy Markdown
Contributor

The GraphQL specification defines that the operation resolution (GetOperation) should happen as part of the request execution. If GetOperation has not yet been called, the graphql.operation.type and graphql.operation.name span attributes can not yet be safely set.
Spans like span.graphql.document.parsing.internal and span.graphql.document.validation.internal that run before the execution should therefore not define these span attributes.

Ref: https://spec.graphql.org/September2025/#sec-Executing-Requests

@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 5, 2026 •

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tobias-tengler / name: Tobias Tengler (9ccc792)

@PascalSenn
PascalSenn merged commit 855f692 into graphql:main Mar 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants