Implemented search_in_response_to - #1676
iamhssingh wants to merge 3 commits into
Conversation
Implemented the concept of `search_in_response_to` in `learn_reposne`. If `previous_statement` is an instance of `chatterbot.conversation.Statement`, learning will save `previous_statement.search_text` as `statement.search_in_response_to`.
Logger statement was removed in the earlier commit by mistake
iamhssingh
left a comment
iamhssingh
left a comment
There was a problem hiding this comment.
Added logger statement, as pointed by @gunthercox
|
@gunthercox anything here expected of me? |
|
@iamhssingh Sorry about the wait, these changes look good and I'll merge them in shortly. |
|
Actually, I just realized that this is missing unit tests. Is there any additional tests cases that can be added to cover these changes? |
|
@gunthercox Sure. I see this change has yet not been implemented. I will write the test cases & update the commit. I am sorry for being this late, bad times! |
|
@gunthercox Are you using Here's the expected behavior of this logic adapter: |
* Fixed doc string * Restructured example to provide more beautiful example
The test cases that are already there takes care of current implementation as well. |
This branch has not been deployed
2 participants
Implemented the concept of
search_in_response_toinlearn_reposne. Ifprevious_statementis an instance ofchatterbot.conversation.Statement, learning will saveprevious_statement.search_textasstatement.search_in_response_to.