Repository navigation
Initialize generated subscription list lazily so MapTo works after deserialization - #151
Open
armadavalor wants to merge 1 commit into
Open
armadavalor wants to merge 1 commit into
armadavalor wants to merge 1 commit into
Conversation
|
@armadavalor is attempting to deploy a commit to the hadashia's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
vitalRouterGeneratedSubscriptionswas a readonly field with an initializer. Initializers are skipped when an instance is created without running a constructor (JSON/binary deserializers,FormatterServices.GetUninitializedObject), so the field stayed null andMapTo/UnmapRoutesthrewNullReferenceException/ArgumentNullExceptiononlock (null).The field is now created lazily in
MapTo(LazyInitializer.EnsureInitialized, thread-safe), andUnmapRoutesreturns early if it was never created.Verification: added
MapToWorksOnInstanceCreatedWithoutConstructortoGeneratedRoutingTest. It fails before the change and passes after. The machine only had the .NET 7 SDK (the test project targets net9.0, the generator uses LangVersion 13), so I ranGeneratedRoutingTestin a scratch net7.0 project compiling the repo sources:Passed! - Failed: 0, Passed: 12, Skipped: 0, Total: 12. I did not run the full suite or Unity.Closes #58