Skip to content

Replace ::snd::pulse::context::async_polyfill::StreamReadNotifier with something more generic #2

Description

@hal7df

StreamReadNotifier is a very simple mechanism that allows the application to only poll PulseAudio for new audio data whenever PulseAudio notifies the application of new audio data.

Its function is not overly specific or complex to the point that it warrants having its own individual implementation -- tokio::sync::Notify has largely the same conceptual purpose -- except the current implementation of StreamReadNotifier appears to be the only approach that I've tried that actually results in an unbroken audio stream in Discord. Other approaches either lead to choppy audio or an application hang when the stream consumer starts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions