Conversation
- index.html: regenerate the embedded EXERCISES with Arabic and add the Arabic tab to the interactive browser, with RTL direction for Arabic steps (dir="rtl" on the instructions list) - README.md: 11 languages everywhere, Arabic added to every language list - scripts/validate-schema.mjs + .github/workflows/validate.yml: schema validation on every push and pull request (ajv, JSON Schema 2020-12) - remove add_ar_placeholders.mjs (one-off migration tool) from the PR
- README.md: Arabic row in the field table, JSON sample, Python and JavaScript examples, and the TypeScript interface - index.html + setup.html: SQL generators now export instructions_fr and instructions_ar in all four dialects (CREATE TABLE columns, INSERT column list and values) — also fixing the pre-existing gap that stopped at instructions_ko - index.html: 11 language tabs scroll horizontally instead of breaking the modal, and RTL direction now applies to the whole instructions container, not only the steps list - scripts/validate-schema.mjs: schema validation plus two permanent content-integrity checks (no verbatim English fallbacks in instructions.ar, no forbidden literal phrases) — enforced by CI - .github/workflows/validate.yml: ajv pinned to ^8
The 11-tab bar overflows horizontally; with 11 tabs the selected one
(e.g. Arabic) can sit outside the visible area on phones. Center the
active tab after rendering, using a direction-agnostic scroll delta —
Chromium's scrollIntoView({inline:'center'}) misses in RTL containers.
Verified in a headless browser at 390px: after tapping العربية the tab
is fully visible.
Author
Review feedback addressed + verification summaryAll review notes from the discussion have been implemented:
Verification
Scope note
Ready for review; happy to adjust anything. |
Author
|
Latest update on this branch:
Before the fix: the tab bar used to flip with the text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds Arabic (
ar) translations for all exercise instructions.What's included
data/exercises.schema.json:aradded to bothlanguageMapandlanguageStepsMap.data/exercises.json: every one of the 1,324 exercises now hasinstructions.ar(full paragraph) andinstruction_steps.ar(ordered step list) — 9,034 Arabic texts in total.index.html: embeddedEXERCISESregenerated with Arabic; the interactive browser gets an Arabic tab, and Arabic steps render withdir="rtl".README.md: language count updated to 11, Arabic added to every language list.scripts/validate-schema.mjs+.github/workflows/validate.yml: schema validation (ajv, JSON Schema 2020-12) runs automatically on every push/PR.Verification evidence
instructions.arvsinstructions.enandinstruction_steps.arvsinstruction_steps.enacross all 1,324 exercises returns 0 identical pairs — every Arabic text is a real translation, not a copied fallback.node scripts/validate-schema.mjs→✓ valid — 1324 exercises against exercises.schema.json(now enforced by CI).Translation methodology
D/V/Y).Notes
add_ar_placeholders.mjs(the one-off migration helper) was removed from the PR after review.