fix: compare oversized numeric prerelease IDs with big.Int - #211
Closed
BetterAndBetterII wants to merge 1 commit into
Closed
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
strconv.ParseInt treated digit-only prerelease identifiers larger than int64 as strings, so 1.2-999... sorted after 1.2-1000.... Parse with math/big and Cmp so SemVer numeric ordering still holds past int64. Fixes hashicorp#204
|
|
Member
|
More AI slop PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comparePartusedstrconv.ParseInt, so digit-only prerelease identifiers larger than int64 fell back to string comparison. That made1.2-99999999999999999999sort after1.2-100000000000000000000.Parse both sides with
math/bigand useCmpso SemVer numeric ordering still holds past int64.Fixes #204
Test plan
go test -count=1 -run '^TestComparePreReleases$' .go test -race -count=1 ./...