correctly compare numeric prerelease values larger than int64 - #212
Merged
Merged
Conversation
Update the comparison function for prerelease segments so that we're comparing numeric identifiers larger than int64 correctly. Because we're only trying to compare them, we don't actually need to convert these to bignums, so do a lexicographical sort to avoid pulling in `math/bigint`. Fixes: #204
jrasell
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the comparison function for prerelease segments so that we're comparing numeric identifiers larger than int64 correctly. Because we're only trying to compare them, we don't actually need to convert these to bignums, so do a lexicographical sort to avoid pulling in
math/bigint.Fixes: #204
Contributor Checklist