Repository navigation
Added lookup functions for multiple files - #75
Conversation
…ctions to return lists directly
ysangkok
left a comment
There was a problem hiding this comment.
It seems like the doctest syntax is invalid. Which doctest implementation did you use?
I have converted all the examples to standard Haddock @ ... @ code blocks to match the rest of servant-multipart. |
|
Thanks. Is this intended to work with |
|
Hello @ysangkok When writing the docstring, I had in mind a checkbox group sharing the same name with explicit value attributes, in which case lookupAllInputs returning list works as intended. I have clarified that in the docs. You're right about standalone checkboxes "on" and absent keys are not suited for lookupInputAs. If you feel lookupInputAs and lookupAllInputsAs introduce too many assumptions or edge cases , I am very happy to drop both and keep this PR strictly focused on the raw lookupAllInputs and lookupAllFiles functions. Let me know what you think! |
|
I think it's fine to keep them. But could you add comments saying which functions take linear time. Because people could assume that functions named |
|
Following #80, I suppose these new functions (and their tests) will have to be moved to |
Co-authored-by: Frederick Pringle <frederick.pringle@fpringle.com>
Co-authored-by: Frederick Pringle <frederick.pringle@fpringle.com>
|
@fpringle I've moved lookup functions to api. |
Let me know if anything else is required. @maksbotan