fix(render): reject unsupported ProRes rate controls - #3702
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MOV renders now reject
--crfand--video-bitrateinstead of silently discarding them. CLI help and rendering docs state that MOV uses one fixed alpha-preserving ProRes 4444 profile across quality tiers.Why
Both flags were accepted and threaded into disk and streaming execution, but each ProRes argument builder returns its fixed 4444 configuration before reading generic rate controls. Different commands therefore produced byte-identical encoder arguments without warning.
How
Format-specific validation runs once in the shared render-plan boundary before disk, streaming, Docker, or batch routing. The error explains that CRF/target bitrate apply to MP4/WebM and directs users to remove the flag or choose one of those formats. ProRes codec, profile, vendor, pixel format, and alpha behavior are unchanged.
Test plan
Unit tests added/updated
Manual testing performed
Documentation updated
Render-plan suite: 15 tests passed, covering both rejected MOV flags and retained MP4/WebM controls
Fixed-profile disk/streaming ProRes controls: 4 tests passed
Changed-file oxlint, oxfmt, and diff checks passed
CLI-wide typecheck remains unavailable because optional AWS/GCP dependencies are absent and unrelated Studio/schema errors predate this change; it reported no changed-path error.