fix(skills): guard canonical stores from mirror aliases - #3714
Open
miguel-heygen wants to merge 1 commit into
Open
fix(skills): guard canonical stores from mirror aliases#3714miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Fallow audit reportFound 1 finding. Details
Generated by fallow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Global skill mirroring now proves that each agent target is filesystem-distinct from the canonical Claude and universal stores before creating, deleting, copying, or linking anything. Symlink aliases and unresolvable loops are skipped and reported, so an update cannot delete the source skill through an alias and replace it with a self-pointing link.
The guard resolves missing tails through their nearest existing ancestor, compares canonical path overlap and device/inode identity, and rechecks immediately before each destructive per-skill operation. A final per-skill symlink remains safe and supported because removal unlinks that entry without traversing its target; this preserves normal Unix idempotency and Windows copy refreshes.
Validation