fix(parsers): allow asset names beginning with two dots - #3759
Draft
javierivanov wants to merge 1 commit into
Draft
fix(parsers): allow asset names beginning with two dots#3759javierivanov wants to merge 1 commit into
javierivanov wants to merge 1 commit into
Conversation
javierivanov
marked this pull request as draft
September 8, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix local asset resolution and containment checks for valid names beginning with two dots, such as
..intro.mp4and..assets/clip.mp4.Why
The checks treated every relative path starting with
..as traversal. As a result, local assets with these names were rejected even when they were inside the project. The candidate resolver returned no candidates, which can produce false missing-asset reports.How
Check for the complete parent-directory segment (
..or..followed by the platform separator). Apply the same distinction to the existing POSIX-normalized root-clamping fallback. Actual parent and sibling paths remain outside the containment boundary.Test plan
bun run --cwd packages/parsers test --configLoader runner src/assetPaths.test.ts src/assetResolution.test.ts src/rewriteSubCompPaths.test.ts.bun run --cwd packages/parsers typecheck.bun run build.ffBinaries.test.tsWindows failures, reproduced against the original code (Windows exe preference and PATH fallback spy count).