Repository navigation
feat(domains): certificate details and TLS modes on hover cards - #151
Merged
Merged
Conversation
…r cards Hovering a domain's certificate badge showed a few lines of text (a hint, the issuer, the expiry), and a Reality / Fake badge only "Fake and Reality TLS domains do not need a certificate of their own". - The domains API reads the stored certificate (cached per PEM): when it was issued, the names it covers, its key and the issuing organisation; with the stored fingerprint and auto-renew. - The certificate badge opens a card in the badge's colour: its state and hint, a bar of the life left with the issue and expiry dates (amber under three weeks, red under one), then issued by, covers, key, auto-renew, fingerprint, and the last error when it failed. - A TLS mode badge (Reality, Fake, DNS, a built-in server's fake-TLS name) opens a card that says what the mode does, that it needs no certificate and which name (SNI) it shows. Solid on the glass themes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Identical pattern | 2 | warning | contribute (via Fink 🐦) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Domains page, hovering a domain's certificate badge ("Valid · N days left") showed a few wrapped lines of white text: a hint, the issuer's short name and the expiry. A Reality / Fake badge only said "Fake and Reality TLS domains do not need a certificate of their own". Admins asked for the certificate's full details and a clearer look.
Change
domains_page_api.py:_tls_outnow also returnsissued_at,names(SANs),key("ECDSA P-256", "RSA 2048"),ca(the issuing organisation), the storedfingerprintandauto_renew. The first four are read from the stored PEM withcryptography,lru_cached per PEM; an unreadable PEM gives nothing.DomainsView.vue: both badges open a hover card (PrimeVue tooltip with escaped HTML, classdm-tip) in the badge's own colour.tlsMode.*Hinttext), that it needs no certificate, and the name (SNI) it shows.domains.tip.*strings in 7 languages.Screenshots
The fingerprint is blurred, because it would identify the test server's certificate in CT logs.
Tested
_cert_factslocally with a generated ECDSA certificate (organisation, SANs, key, issue date) and with garbage, which returns{}.vue-tsc: no errors in the changed files.Review
🤖 Generated with Claude Code