Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
========================================
Coverage 58.61% 58.61%
========================================
Files 14 14
Lines 6036 6036
Branches 1421 1421
========================================
Hits 3538 3538
Misses 1923 1923
Partials 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Wave D item 18, minimal-scope variant. The five workflow files that
run the identical SYNC+ASYNC suite against different HDF5 versions
(1.14.0, 1.14.1, 2.0.0, 2.1.1, 2.2.0) collapse into a single matrix
workflow. The four older SYNC-only files (1.10.4, 1.10.7, 1.10.8,
1.12.0) stay as-is because their test set is a strict subset and
they don't run the ASYNC leg; collapsing them would require
conditional gates that make the matrix noisier than the win.
## New file
.github/workflows/h5bench-hdf5-matrix.yml
- strategy.fail-fast: false so one bad version does not cancel
the others
- strategy.matrix.hdf5_version: [1.14.0, 1.14.1, 2.0.0, 2.1.1, 2.2.0]
- container.image: hpcio/hdf5-${{ matrix.hdf5_version }}
- job name: "h5bench (HDF5 ${{ matrix.hdf5_version }})" so each
matrix leg reports as e.g. "h5bench (HDF5 2.0.0)", matching the
old per-version workflow's job name as closely as possible.
## Deleted
.github/workflows/h5bench-hdf5-1.14.0.yml
.github/workflows/h5bench-hdf5-1.14.1.yml
.github/workflows/h5bench-hdf5-2.0.0.yml
.github/workflows/h5bench-hdf5-2.1.1.yml
## Branch protection
Required-check names WILL shift. The old checks appeared as
"h5bench (HDF5 X.X.X) / h5bench"; the new ones appear as
"h5bench / h5bench (HDF5 X.X.X)". Any required-check rules on
develop/master that name the old paths must be updated before
this merges, or the required checks will hang.
## Coordination with #166 (2.2.0)
If #166 lands first, its h5bench-hdf5-2.2.0.yml must be deleted on
rebase of this PR (it is redundant with the matrix leg). If this PR
lands first, #166 should drop the per-version file and just push the
image.
jeanbez
force-pushed
the
workflow-matrix
branch
from
August 12, 2026 18:16
a2a4bef to
0d5113f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave D item 18, minimal-scope variant. Five workflow files that run the identical SYNC+ASYNC suite against different HDF5 versions collapse into a single matrix workflow.
The four older SYNC-only files (1.10.4, 1.10.7, 1.10.8, 1.12.0) stay as-is because their test set is a strict subset and they don't run ASYNC. Collapsing them would need conditional gates that make the matrix noisier than the win.
Summary
Added: `.github/workflows/h5bench-hdf5-matrix.yml`
Deleted: the four per-version workflow files for 1.14.0, 1.14.1, 2.0.0, 2.1.1.
Branch protection
Required-check names WILL shift. Old checks appeared as `h5bench (HDF5 X.X.X) / h5bench`; new ones appear as `h5bench / h5bench (HDF5 X.X.X)`. Any required-check rules on develop/master that name the old paths must be updated before this merges, or those required checks will hang forever.
Coordination with #166 (2.2.0)
If #166 lands first, its `h5bench-hdf5-2.2.0.yml` must be deleted on rebase of this PR (redundant with the matrix leg). If this PR lands first, #166 should drop that per-version file and just push the image.
Test plan