Conversation
jeanbez
force-pushed
the
add-mpi-launchers
branch
from
August 19, 2026 06:02
204c851 to
05eca5d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #171 +/- ##
===========================================
+ Coverage 58.85% 58.87% +0.01%
===========================================
Files 14 14
Lines 6062 6064 +2
Branches 1427 1428 +1
===========================================
+ Hits 3568 3570 +2
Misses 1917 1917
Partials 577 577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #170. The schema's mpi.command enum previously listed mpirun, mpiexec, srun, jsrun, and runjob. Two problems with that list: * jsrun, lrun (Sierra/Lassen wrapper), and runjob (BlueGene/Q) all target systems that are decommissioned or actively winding down; keeping them in the enum implies support this project no longer validates against. * Several launchers still in production use (ibrun on TACC, aprun on remaining Crays, flux run on LLNL Tioga, prun on Cray PALS) were missing entirely. Three touchpoints: * schemas/h5bench-config.schema.json: replace the enum with [mpirun, mpiexec, srun, ibrun, aprun, flux run, prun]. Description documents the rank-flag mapping and notes the legacy launchers can be re-added if a live system needs them. * src/h5bench.py check_parallel: shell-blacklist now matches the enum (ibrun, aprun, prun added; jsrun/lrun not added). * src/h5bench.py prepare_parallel: dispatches ibrun/aprun/flux run/prun to "-n <ranks>", their common convention. Tests: parametrised test in test_driver_unit.py covers each of the four new launchers via the ranks path.
jeanbez
force-pushed
the
add-mpi-launchers
branch
from
August 20, 2026 01:13
05eca5d to
0470824
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170.
The schema's `mpi.command` enum previously listed `mpirun`, `mpiexec`, `srun`, `jsrun`, `runjob`. Two problems: several currently-used launchers were missing, and three of the listed launchers target systems that are decommissioned or actively winding down.
Additions
Removals
Users on any of the removed systems can re-add the entry locally, or fall back to the raw `command` string once the enum is opened up.
Touchpoints
Tests
Parametrised test in `test_driver_unit.py` covers each of the four new launchers via the `ranks:` path.
Test plan