Record is_border_4() as deliberately retained, not orphaned - #13
Closed
billdenney wants to merge 1 commit into
Closed
Record is_border_4() as deliberately retained, not orphaned#13billdenney wants to merge 1 commit into
billdenney wants to merge 1 commit into
Conversation
The 2026-07-28 no-consumer audit re-confirmed that src/thinr_common.h's is_border_4() has no caller: no .cpp references it, and the only other mention was the CLAUDE.md line listing it as a shared helper. Its last callers were the stentiford and pavlidis kernels, dropped 2026-05-20. thinr's own REVIEW-2026-07-28.md left the choice open -- "delete the is_border_4 definition and the CLAUDE.md mention, or add a comment stating it is retained deliberately" -- and deliberately did not decide. This commit takes the second option and closes the ambiguity, which is the point of the audit: the helper is part of the shared 8-neighbour vocabulary a new thinning kernel is written against, an uncalled inline emits no code, and the standing instruction is not to remove code that is likely to be useful merely because it has no consumer yet. No behaviour change: comments only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Member
Author
|
Superseded by #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-07-28 no-consumer audit re-confirmed that src/thinr_common.h's is_border_4() has no caller: no .cpp references it, and the only other mention was the CLAUDE.md line listing it as a shared helper. Its last callers were the stentiford and pavlidis kernels, dropped 2026-05-20.
thinr's own REVIEW-2026-07-28.md left the choice open -- "delete the is_border_4 definition and the CLAUDE.md mention, or add a comment stating it is retained deliberately" -- and deliberately did not decide. This commit takes the second option and closes the ambiguity, which is the point of the audit: the helper is part of the shared 8-neighbour vocabulary a new thinning kernel is written against, an uncalled inline emits no code, and the standing instruction is not to remove code that is likely to be useful merely because it has no consumer yet.
No behaviour change: comments only.