chore(deps): bump the actions group across 1 directory with 2 updates - #80
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps the actions group with 2 updates in the / directory: [github/codeql-action](https://github.com/github/codeql-action) and [dawidd6/action-send-mail](https://github.com/dawidd6/action-send-mail). Updates `github/codeql-action` from 4.37.8 to 4.37.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4.37.8...v4.37.9) Updates `dawidd6/action-send-mail` from 3.12.0 to 18 - [Release notes](https://github.com/dawidd6/action-send-mail/releases) - [Commits](dawidd6/action-send-mail@v3.12.0...v18) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.37.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: dawidd6/action-send-mail dependency-version: '18' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The PR updates GitHub Actions for CodeQL and email notifications. While the updates align with the PR intent, the upgrade to version 18 for dawidd6/action-send-mail is a significant major version jump that may introduce breaking changes. Additionally, a high-severity security concern was identified: pinning actions to mutable tags rather than commit SHAs reduces build determinism and exposes the pipeline to supply chain risks. No automated tests were found verifying these workflow updates.
About this PR
- The upgrade for 'dawidd6/action-send-mail' is a major version jump from 3.12.0 to 18. Major version transitions in actions often introduce breaking changes to inputs or required Node.js environments. As no automated verification for this workflow was found in the PR, this should be manually verified or tested before merging.
Test suggestions
- Verify that the CodeQL Security Analysis workflow successfully initializes and performs analysis using the new default bundle version (2.26.4).
- Verify that the Push email notification workflow correctly authenticates and sends emails using the major version 18 of the send-mail action.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the CodeQL Security Analysis workflow successfully initializes and performs analysis using the new default bundle version (2.26.4).
2. Verify that the Push email notification workflow correctly authenticates and sends emails using the major version 18 of the send-mail action.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
| uses: dawidd6/action-send-mail@v18 |
There was a problem hiding this comment.
🔴 HIGH RISK
The workflow pins dawidd6/action-send-mail using a version tag ('v18') rather than a commit SHA. Version tags are mutable, which means the underlying code can change without warning, posing a security risk and reducing build determinism. To secure your pipeline and ensure the integrity of your software supply chain, it is recommended to pin the action to a specific commit SHA.
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the actions group with 2 updates in the / directory: github/codeql-action and dawidd6/action-send-mail.
Updates
github/codeql-actionfrom 4.37.8 to 4.37.9Release notes
Sourced from github/codeql-action's releases.
Changelog
Sourced from github/codeql-action's changelog.
Commits
cdf488fMerge pull request #4107 from github/update-v4.37.9-920ba7cd17243f38Update changelog for v4.37.9920ba7cMerge pull request #4106 from github/update-bundle/codeql-bundle-v2.26.4ecfa6e1Add changelog noteadcdf4aUpdate default bundle to codeql-bundle-v2.26.4486fec2Merge pull request #4099 from github/update-supported-enterprise-server-versions134624cMerge pull request #4101 from github/dependabot/npm_and_yarn/npm-minor-457d82...ff43db8Merge pull request #4103 from github/mergeback/v4.37.8-to-main-db488dde4605e03Rebuild099c869Update changelog and version after v4.37.8Updates
dawidd6/action-send-mailfrom 3.12.0 to 18Release notes
Sourced from dawidd6/action-send-mail's releases.
... (truncated)
Commits
94de994fix: Use extended HELLO with github.com domain (#302)6e50282build(deps): bump actions/checkout from 6 to 7 (#300)1d138f3build(deps): bump nodemailer from 9.0.0 to 9.0.1 (#299)1369c5bnode_modules: update (#297)d86d472build(deps): bump nodemailer from 8.0.11 to 9.0.0 (#296)19dc783build(deps): bump nodemailer from 8.0.10 to 8.0.11 (#295)0dd1be8build(deps): bump nodemailer from 8.0.9 to 8.0.10 (#294)6bf8b9cbuild(deps): bump nodemailer from 8.0.8 to 8.0.9 (#293)51e2c0dbuild(deps): bump nodemailer from 8.0.7 to 8.0.8 (#292)076b075build(deps): bump brace-expansion from 5.0.5 to 5.0.6 (#291)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions