Repository navigation
fix(client): restore startup with sing-box 1.14 and VPN-routed nodes - #673
Open
coolsnowwolf wants to merge 2 commits into
Open
coolsnowwolf wants to merge 2 commits into
coolsnowwolf wants to merge 2 commits into
Conversation
Replace legacy inbound sniff fields with a route sniff action after DNS hijacking. Remove obsolete DNS cache options and invalid action fields from the default domain resolver. Keep sniffing for routing without destination override: the installed sing-box 1.14.2 rejects override_destination in a sniff action. Signed-off-by: coolsnowwolf <coolsnowwolf@gmail.com>
Automatic interface detection binds outgoing connections to the default WAN interface. This prevents reaching a proxy node through a more specific VPN route and can make initial remote rule-set downloads fail. Skip automatic interface binding when self_mark already exempts outgoing sockets from interception. Preserve explicit interface selection and automatic detection when no self mark is configured. Signed-off-by: coolsnowwolf <coolsnowwolf@gmail.com>
petermaple
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After upgrading to sing-box 1.14.2, HomeProxy fails its client configuration check because it still generates legacy inbound
sniffandsniff_override_destinationfields. These fields were removed in sing-box 1.13.After fixing configuration decoding, a second startup failure was reproduced with a SOCKS node reachable through a VPN. Automatic interface detection binds outgoing connections to the default WAN interface instead of following the more specific VPN route. Initial remote rule-set downloads then time out and sing-box exits, even though the same node works through the system routing table.
Change
Two commits address the independently reproduced failures:
actionfields fromdefault_domain_resolver.self_markalready exempts outgoing sockets from interception, allowing system routes to reach VPN-hosted nodes. Explicit interface selection and automatic detection without a self mark remain available.The configuration migration was informed by #671. Its
override_destinationfield was tested on the installed sing-box 1.14.2 and rejected withroute.rules[1].override_destination: json: unknown field "override_destination". This PR therefore uses the supported routesniffaction with a 300 ms timeout. Sniffed metadata remains available for routing, but the old destination-override behavior is not retained. Server ACME migration and Snell support are outside this client startup fix.Validation
Tested on an AX5 running QSDK/OpenWrt with sing-box 1.14.2, using
bypass_mainland_china,redirect_tproxy, and a SOCKS node reached over a VPN.sing-box check.sing-box check.git diff --check.The upstream generator at
edece28is identical to the tested downstream baseline. Validation covers the active client configuration; custom routing, TUN modes, server configurations, reboot behavior and a full upstream firmware build were not tested. Existing 1.16 deprecation warnings are not addressed by this fix.