Skip to content

fix: respect skill framework casing, hide codes on alignment cards - #775

Merged
daniel-mader merged 4 commits into
devfrom
fix/alignment-cards
Oct 9, 2026
Merged

daniel-mader merged 4 commits into
devfrom
fix/alignment-cards

Conversation

@coplat

@coplat coplat commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of change

  • Known skill frameworks are shown in their own spelling whatever the issuer's casing (ESCO, CompetentNL);
  • Hide codes: targetCode is no longer shown on the card. ESCO codes were already hidden (UUIDs), but other frameworks' codes (e.g. CompetentNL's 1DDD1C4672) were shown, even though they are just noise to the user. The code is still required to treat an alignment as an official skill.

Testing

Added unit tests for framework display names.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Updates
    • Framework names now use consistent canonical casing for ESCO and CompetentNL.
    • Official skill entry codes are no longer displayed. Framework links appear on a separate, right-aligned row, and uppercase styling is limited to the skill type.
    • Updated skill details present framework information without entry codes.

@coplat coplat self-assigned this Oct 7, 2026
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 34031e42-3267-41d7-9a58-c52b307e26c3

📥 Commits

Reviewing files that changed from the base of the PR and between dabaf98 and d0da81b.


📒 Files selected for processing (4)
  • unime/src/lib/utils/alignment.test.ts
  • unime/src/lib/utils/alignment.ts
  • unime/src/routes/credentials/[id]/(renderers)/AlignmentRenderer.svelte
  • unime/src/routes/credentials/[id]/(renderers)/AlignmentRenderer.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The alignment utility no longer returns skill codes and displays selected framework names with canonical casing. The credential renderer no longer shows skill codes and limits uppercase styling to the skill-kind label.

Changes

Alignment display

Layer / File(s) Summary
Resolve official skill details
unime/src/lib/utils/alignment.ts, unime/src/lib/utils/alignment.test.ts
OfficialSkill no longer includes a code. findOfficialSkill returns canonical casing for ESCO and CompetentNL framework names and preserves other supplied names. Tests cover the returned shape and framework casing.
Render alignment details
unime/src/routes/credentials/[id]/(renderers)/AlignmentRenderer.svelte, unime/src/routes/credentials/[id]/(renderers)/AlignmentRenderer.test.ts
The renderer no longer displays skill codes. It places the optional framework link on a separate right-aligned row and applies uppercase styling only to the skill-kind label. The test checks that the ESCO skill code is absent.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: daniel-mader


Merge Risk: ⚪ Minimal · up to d0da8

The change hides skill codes on alignment cards and canonicalizes selected framework names. UUID-coded alignments retain their existing name and link behavior, leaving no identified merge-blocking risk beyond normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly summarizes both primary changes: preserving skill framework casing and hiding alignment codes.
Description check Passed The description explains the main changes, includes testing information, and completes the definition-of-done checklist. It does not reference a specific issue or provide detailed test commands, but i…

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)



  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coplat coplat changed the title fix: alignment cards for skills fix: show skill framework names in their own casing and hide codes on alignment cards Oct 7, 2026
@coplat coplat changed the title fix: show skill framework names in their own casing and hide codes on alignment cards fix: show skill framework names in their own casing, hide codes on alignment cards Oct 7, 2026
@coplat
coplat marked this pull request as ready for review October 7, 2026 11:24
@daniel-mader daniel-mader changed the title fix: show skill framework names in their own casing, hide codes on alignment cards fix: respect skill framework casing, hide codes on alignment cards Oct 9, 2026
@daniel-mader
daniel-mader merged commit 91b3bc7 into dev Oct 9, 2026
4 checks passed
@daniel-mader
daniel-mader deleted the fix/alignment-cards branch October 9, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants