Repository navigation
fix: respect skill framework casing, hide codes on alignment cards - #775
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe alignment utility no longer returns skill codes and displays selected framework names with canonical casing. The credential renderer no longer shows skill codes and limits uppercase styling to the skill-kind label. ChangesAlignment display
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change hides skill codes on alignment cards and canonicalizes selected framework names. UUID-coded alignments retain their existing name and link behavior, leaving no identified merge-blocking risk beyond normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)✅ Passed checks (4 passed)Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description of change
ESCO,CompetentNL);targetCodeis no longer shown on the card. ESCO codes were already hidden (UUIDs), but other frameworks' codes (e.g. CompetentNL's1DDD1C4672) were shown, even though they are just noise to the user. The code is still required to treat an alignment as an official skill.Testing
Added unit tests for framework display names.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.Summary by CodeRabbit