[BUGFIX] Avoid exceptions on NULL pi_flexform - #1394
Open
YKWeyer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The default value of the
pi_flexformcolumn in the database isNULL.It is possible for editors to reach that state e.g. by changing the CType of an existing ContentElement, but
GeneralUtility::xml2array(used inconvertFlexFormContentToArray) expects a string, causing PHP exceptions in the backend.How to reproduce
CTypefield to PowermailRefresh requiredpopup appears, selectSave and refreshOpening the page view in the backend will return a PHP exception:
Changes
When
pi_flexformis null, then the rendering of the preview is skipped. Only an error message will be displayed in the backend: