Repository navigation
Merge main into release/v3.x-new in order to prepare for v3.6.17 release - #452
Conversation
* reworked script and config for hydro governance hub deployment * adjust script to instantiate the executive dao as well * script cleanup
* Add mandatory timeout to SubmitDeployedAmount SubmitDeployedAmount proposals are executed via DAO DAO with a proposer and a separate verifier. If the verifier verifies but fails to execute, the proposal stays executable indefinitely, so a compromised EOA could execute a very old, stale submission. The message now carries a required timeout (Unix timestamp in nanoseconds); execution fails with a new SubmissionExpired error if env.block.time is past it. * Add changelog entry for SubmitDeployedAmount timeout
* IBC Eureka Inflow adapter implementation * adjusted changelog * Executors must provide fees on their own when initiating IBC Eureka transfers * Have the relaying quote be specified by the executor * recompiled contracts
…448) * Add ability to swap the deposit denom on the Inflow Cosmos Hub vault * Add changelog entry for deposit denom swap * Check adapter positions, token info provider and shares denom on deposit denom swap * Rebuild artifacts and regenerate schemas
|
Review Summary This PR merges New IBC Eureka Inflow adapter ( Overall well structured and thoroughly tested ( A few minor observations, none blocking:
SubmitDeployedAmount timeout (control-center) Clean, minimal fix for the "stale DAO proposal executes an old submission" problem. The boundary test ( SwapDepositDenom (vault-cosmoshub) Good defensive design — checks vault balance, all registered adapters' bank balances, and adapter-reported deployed positions before allowing the swap, and fails closed if a position query errors out. Test coverage is thorough (success, non-empty withdrawal queue, denom-still-held for vault/tracked/untracked adapters, shares-denom collision, provider-not-supporting-new-denom, position-query-failure, unauthorized, same-denom). One thing worth double-checking outside the code (can't verify from the diff alone): the doc comment on lsm-hub-token-info-provider validator ratio fix The rewrite of Other changes
Checklist / housekeeping Artifacts, schemas, and changelog entries ( No security concerns identified beyond the notes above — access control (admin/executor/depositor roles) is checked consistently across the new adapter's execute handlers, and the EVM destination-address allowlist plus role separation (executors can't add new destinations themselves) limits the blast radius of a compromised executor key to funds routed to already-approved addresses. |
Description
Closes: #XXXX
Add a description of the changes that this PR introduces and the files that
are the most critical to review.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
.changelogmake compileand included content of the artifacts directory into the PRmake schemaand included generated files into the PR