Port improvements v2 - #185
Conversation
Dockerfile hard-coded PRODUCTION_BUILD=false, causing dummy plugins (dummy-alertmanager, dummy-events, dummy-metrics, dummy-logs) to ship in release images. Set PRODUCTION_BUILD=true in Dockerfile so OMIT_TRANSPORTS applies. Also add '//go:build !production' tag to all dummy plugins as defense-in-depth. Pass -tags production in build.sh when PRODUCTION_BUILD=true. Related-To: OSPRH-33326 Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Daniel Pawlik <dpawlik@redhat.com> (cherry picked from commit 8acf3c9)
…tch#183) Replace unbounded per-event goroutine spawning with a fixed worker pool to prevent memory/fd exhaustion when the Alertmanager endpoint is slow or unreachable. Share a single http.Client with a 10s timeout instead of creating a new zero-timeout client per request. Add early returns on request creation errors to prevent nil-pointer dereference. Close the response body on all paths to prevent TCP connection leaks. Assisted-By: Claude-Code claude-opus-4-6 (cherry picked from commit 4671bbf)
|
Waiting #184 to be merged |
vyzigold
left a comment
vyzigold
left a comment
There was a problem hiding this comment.
lgtm assuming 184 merges first
|
Build failed (check pipeline). Post ✔️ stf-crc-ocp_418-local_build SUCCESS in 57m 01s |
2 participants
f766243 Fix resource exhaustion and nil-deref in alertmanager plugin (#183)
c273f19 Exclude dummy transport plugins from production container image (#184)