Conversation
Member
|
Hey @mahlingam, thanks for submitting this PR! The build failed - are you going to work on it? |
Member
|
And sorry that I just caused merge conflicts, that wasn't intended. |
Author
afaik, solr 10 now requires jdk21, but the github action uses jdk11, otherwise the build should succeed. I might also include .github/workflows/scala.yml with jdk21 just for my branch. |
Member
|
I'd say updating to jdk21 together with solr 10 makes sense 👍 |
…0.0.0 # Conflicts: # build.sbt
Member
|
@mahlingam Are you going to update to jdk21 in .github/workflows/scala.yml as well, in order to fix the PR build? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.