tdx: document attestation flow for TDX VMs - #13
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Intel TDX attestation documentation covering prerequisites, QGS socket behavior, quote generation, and verification.
Changes:
- Documents host and guest prerequisites.
- Explains QGS UNIX-socket configuration.
- Adds quote-generation and optional verification steps.
Review findings:
- Moderate: Explicitly document that QGS must use the required UNIX-socket transport and path.
- Nit: Use
./test_tdx_attestin the sample commands.
Suppressed comments (3)
docs/intel_tdx.md:181
- This link targets Intel's
intel-innersourcerepository and themain-internalref; it is not publicly resolvable (the referenced ref returns 404), so external users cannot follow the optional verification step. Link to a public verification sample or include a verification procedure/source available to the documented audience.
4. (Optional) Download `quote.dat` to the host and verify it with [QuoteVerificationSample](https://github.com/intel-innersource/frameworks.security.confidential-computing.tee.dcap/tree/main-internal/SampleCode/QuoteVerificationSample).
docs/intel_tdx.md:179
- The listed guest packages do not guarantee that
makeor a C compiler is installed. On a standard cloud image, following the prerequisites can therefore fail withmake: command not foundbefore the sample is built. Add the guest build-tool prerequisite, or provide a prebuilt-sample path, before this step.
2. Run `cd /opt/intel/tdx-quote-generation-sample && make` to build `test_tdx_attest`.
docs/intel_tdx.md:180
- The
/dev/tdx_guestcharacter device is normally restricted to root or an appropriate device group, so running the sample as the ordinary VM user can fail with permission denied. State the required access, for example by invoking the sample withsudo, or document the udev/device-permission setup.
3. Run `test_tdx_attest` to generate a local quote file named `quote.dat`.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| 1. Launch the TDX VM with no special Cloud Hypervisor arguments. | ||
| 2. Run `cd /opt/intel/tdx-quote-generation-sample && make` to build `test_tdx_attest`. | ||
| 3. Run `test_tdx_attest` to generate a local quote file named `quote.dat`. |
|
|
||
| #### Cloud Hypervisor Arguments | ||
|
|
||
| 1. No additional Cloud Hypervisor arguments are required for TDX attestation, and the VMM connects automatically to the QGS UNIX socket (`/var/run/tdx-qgs/qgs.socket`). |
Add an Attestation section to the Intel TDX documentation, including host and guest prerequisites, Cloud Hypervisor argument behavior for QGS socket usage, and quote generation and optional verification steps. Signed-off-by: Liang, Zhou <liang1.zhou@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an Attestation section to the Intel TDX documentation, including host and guest prerequisites, Cloud Hypervisor argument behavior for QGS socket usage, and quote generation and optional verification steps.