Skip to content

tdx: document attestation flow for TDX VMs - #13

Merged
guzongmin merged 1 commit into
mainfrom
zhoul1/dev/tdx_readme_2
Aug 25, 2026
Merged

tdx: document attestation flow for TDX VMs#13
guzongmin merged 1 commit into
mainfrom
zhoul1/dev/tdx_readme_2

Conversation

@liangzhou121

Copy link
Copy Markdown
Contributor

Add an Attestation section to the Intel TDX documentation, including host and guest prerequisites, Cloud Hypervisor argument behavior for QGS socket usage, and quote generation and optional verification steps.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Intel TDX attestation documentation covering prerequisites, QGS socket behavior, quote generation, and verification.

Changes:

  • Documents host and guest prerequisites.
  • Explains QGS UNIX-socket configuration.
  • Adds quote-generation and optional verification steps.

Review findings:

  • Moderate: Explicitly document that QGS must use the required UNIX-socket transport and path.
  • Nit: Use ./test_tdx_attest in the sample commands.
Suppressed comments (3)

docs/intel_tdx.md:181

  • This link targets Intel's intel-innersource repository and the main-internal ref; it is not publicly resolvable (the referenced ref returns 404), so external users cannot follow the optional verification step. Link to a public verification sample or include a verification procedure/source available to the documented audience.
4. (Optional) Download `quote.dat` to the host and verify it with [QuoteVerificationSample](https://github.com/intel-innersource/frameworks.security.confidential-computing.tee.dcap/tree/main-internal/SampleCode/QuoteVerificationSample).

docs/intel_tdx.md:179

  • The listed guest packages do not guarantee that make or a C compiler is installed. On a standard cloud image, following the prerequisites can therefore fail with make: command not found before the sample is built. Add the guest build-tool prerequisite, or provide a prebuilt-sample path, before this step.
2. Run `cd /opt/intel/tdx-quote-generation-sample && make` to build `test_tdx_attest`.

docs/intel_tdx.md:180

  • The /dev/tdx_guest character device is normally restricted to root or an appropriate device group, so running the sample as the ordinary VM user can fail with permission denied. State the required access, for example by invoking the sample with sudo, or document the udev/device-permission setup.
3. Run `test_tdx_attest` to generate a local quote file named `quote.dat`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/intel_tdx.md

1. Launch the TDX VM with no special Cloud Hypervisor arguments.
2. Run `cd /opt/intel/tdx-quote-generation-sample && make` to build `test_tdx_attest`.
3. Run `test_tdx_attest` to generate a local quote file named `quote.dat`.
Comment thread docs/intel_tdx.md

#### Cloud Hypervisor Arguments

1. No additional Cloud Hypervisor arguments are required for TDX attestation, and the VMM connects automatically to the QGS UNIX socket (`/var/run/tdx-qgs/qgs.socket`).
@guzongmin
guzongmin merged commit 5052f20 into main Aug 25, 2026
17 of 43 checks passed
Add an Attestation section to the Intel TDX documentation, including host and guest prerequisites, Cloud Hypervisor argument behavior for QGS socket usage, and quote generation and optional verification steps.

Signed-off-by: Liang, Zhou <liang1.zhou@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants