Add optional libnuma / accel-config support#31
Open
byrnedj wants to merge 1 commit into
Open
Conversation
Guard the accel-config and numa dependencies behind DTO_ACCEL_CONFIG_SUPPORT and DTO_NUMA_SUPPORT #ifdefs in dto.c so the library can be built without either. Add matching CMake options (on by default, plus static-link variants) and thread the -D defines through the Makefile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 8, 2026
jsydir
approved these changes
Jul 22, 2026
jsydir
left a comment
jsydir
left a comment
Contributor
There was a problem hiding this comment.
This PR is approved for merging.
Contributor
There was a problem hiding this comment.
Is it an error that -lnuma and -laccel-config still appear in the gcc command lines
Contributor
There was a problem hiding this comment.
It would be good to add some text to the readme describing these options and saying how to configure them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 2/3 — stacked on
cmake-build-system(#30).Guards the accel-config and numa dependencies behind
DTO_ACCEL_CONFIG_SUPPORTand
DTO_NUMA_SUPPORT#ifdefs indto.cso the library can be built withouteither. Adds matching CMake options (on by default, plus static-link variants)
and threads the
-Ddefines through the Makefile.