Ipu7 psys register psys node before add device and debugfs - #90
Open
arunt1 wants to merge 3 commits into
Open
Conversation
arunt1
changed the title
manikx
reviewed
Jul 21, 2026
| struct dentry *file; | ||
| struct dentry *dir; | ||
|
|
||
| #if LINUX_VERSION_CODE < KERNEL_VERSION(6,17,0) |
There was a problem hiding this comment.
23: ERROR: space required after that ',' (ctx:VxV).
Space always after a comma. Space never before comma.
#if LINUX_VERSION_CODE < KERNEL_VERSION(6,17,0)
#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 17, 0)
manikx
reviewed
Jul 21, 2026
| #if LINUX_VERSION_CODE < KERNEL_VERSION(6,17,0) | ||
| dir = debugfs_create_dir("psys", psys->adev->isp->ipu7_dir); | ||
| #else | ||
| dir = debugfs_create_dir("ipu7-psys",NULL); |
There was a problem hiding this comment.
26: ERROR: space required after that ',' (ctx:VxV)
Space always after a comma. Space never before comma.
dir = debugfs_create_dir("ipu7-psys",NULL);
dir = debugfs_create_dir("ipu7-psys", NULL);
manikx
reviewed
Jul 21, 2026
manikx
left a comment
manikx
left a comment
There was a problem hiding this comment.
Suggestion: Consider adding some description about the commit or add an empty line.
media:ipu7: register psys node before add device
Reordering bus and auxiliary driver registration as required by v7.1 code logic
Signed-off-by: Arun T <arun.t@intel.com>
Reordering bus and auxiliary driver registration as required by v7.1 code logic Signed-off-by: Arun T <arun.t@intel.com>
Signed-off-by: Arun T <arun.t@intel.com>
Signed-off-by: Arun T <arun.t@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error 1:
[ 4.352252] bus_add_device: cannot add device 'ipu7-psys0' to unregistered bus 'intel-ipu7-psys'
[ 4.362394] intel-ipu7-psys ipu7-psys0: psys device_register failed
[ 4.370175] intel_ipu7_psys.psys intel_ipu7.psys.40: probe with driver intel_ipu7_psys.psys failed with error -22
Fix Patch:
psys_probe is not passed when calling only module_auxiliary_driver(), from 7.1 code logic get changed we need to call first bus register so that auxiliary_driver_register register bus driver (psys) properly
Error2:
A kernel panic was observed when creating the PSYS DebugFS directory. The crash occurs because psys->adev->isp->ipu7_dir is NULL or invalid at that point. The fix uses a safe, standalone directory:
Fix:
added proper ipu7-psys node name in debugfs_create()