Skip to content

[raftstore] Store / Consensus shutdown is incomplete #1610

Description

@MariemBaccari

As flagged in #1525, the Raftstore shutdown is never triggered.

  • Store.Close() is not called anywhere. It should be called in main.go.
  • It should also takes a context.Context argument to be passed down to the consensus instance.
  • Consensus.Stop() ignored the context argument and builds its own instead.
  • It also attempts its own cleanup with defer c.Stop(context.Background()). Removing this should allow the removal of the once.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions