[raft/aux] Add aux Raftstore - #1528
Merged
Merged
Conversation
MariemBaccari
force-pushed
the
add_aux
branch
3 times, most recently
from
June 15, 2026 13:44
235e51e to
e9ece61
Compare
the-glu
reviewed
Jun 15, 2026
MariemBaccari
force-pushed
the
add_aux
branch
2 times, most recently
from
June 15, 2026 14:52
9566c32 to
5d13119
Compare
MariemBaccari
force-pushed
the
add_aux
branch
5 times, most recently
from
June 16, 2026 09:18
8f85bb5 to
9e8af65
Compare
MariemBaccari
marked this pull request as ready for review
June 16, 2026 09:24
the-glu
approved these changes
Jun 16, 2026
barroco
added
the
dss-raft
This was referenced Jun 18, 2026
MariemBaccari
force-pushed
the
add_aux
branch
3 times, most recently
from
June 18, 2026 09:41
86221f4 to
3739510
Compare
MariemBaccari
force-pushed
the
add_aux
branch
3 times, most recently
from
August 11, 2026 10:04
ee4d690 to
37048f7
Compare
This was referenced Aug 11, 2026
mickmis
approved these changes
Aug 18, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, but several minor comments
MariemBaccari
force-pushed
the
add_aux
branch
4 times, most recently
from
August 19, 2026 08:10
7f4f1a4 to
5c9ca72
Compare
This was referenced Aug 19, 2026
mickmis
approved these changes
Aug 19, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
- I have more suggestions opportunities for simplifications / clarity
- In addition: by removing the validation from the store itself, we are now expecting the caller to provide correct parameters, otherwise unexpected behavior might occur. I think that is alright since anyway the store interface the the logic calling it are tightly coupled, however we should ensure a future dev knows what are valid parameters. I propose to add this to the documentation of the interface methods (https://github.com/interuss/dss/blob/2bf6aa7a410f76c590f78c70be324352c91a72a4/pkg/aux_/repos/repos.go).
mickmis
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PR: #1622 -> #1528 -> #1626 -> #1597 -> #1623 -> #1627 -> #1642 -> #1643
Implements the aux Raftstore.
Removes the registry as it is not needed by aux which only calls
Interact.Implements the aux repo which calls the consensus instance for each type of operation (except
GetDSSAirspaceRepresentationIDwhich is local).