Skip to content

[raft/rid] Raftstore skeleton #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickmis merged 1 commit into from
Aug 26, 2026
Merged

[raft/rid] Raftstore skeleton #1623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 41 additions & 8 deletions pkg/rid/store/raftstore/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,70 @@ package raftstore
import (
"context"

dsserr "github.com/interuss/dss/pkg/errors"
"github.com/interuss/dss/pkg/memstore"
"github.com/interuss/dss/pkg/raftstore"
"github.com/interuss/dss/pkg/raftstore/consensus"
"github.com/interuss/dss/pkg/rid/actions"
"github.com/interuss/dss/pkg/rid/repos"
ridmemstore "github.com/interuss/dss/pkg/rid/store/memstore"
ridraftparams "github.com/interuss/dss/pkg/rid/store/raftstore/params"
"github.com/interuss/stacktrace"
"go.uber.org/zap"
)

// repo is a full implementation of rid.repos.Repository for Raft-based storage.
type repo struct{}
type repo struct {
consensus *consensus.Consensus
memStore *memstore.Store[repos.Repository]
memRepo repos.Repository
}

func Init(ctx context.Context, logger *zap.Logger) (*raftstore.Store[repos.Repository], error) {
params, err := ridraftparams.GetConnectParameters()
if err != nil {
return nil, stacktrace.Propagate(err, "failed to get rid raft parameters")
}
return raftstore.Init(ctx, logger.With(zap.String("service", "rid")), params, &repo{}, actions.Registry)

memStore, err := ridmemstore.Init(ctx, logger)
if err != nil {
return nil, stacktrace.Propagate(err, "failed to initialize rid memstore")
}

r := &repo{memStore: memStore, memRepo: memStore.GetRepo()}
store, err := raftstore.Init(ctx, logger.With(zap.String("service", "rid")), params, r, actions.Registry)
if err != nil {
return nil, stacktrace.Propagate(err, "failed to initialize rid raftstore")
}

r.consensus = store.Consensus

return store, nil
}

func (r *repo) GetRepo() repos.Repository { return r }

func (r *repo) GetSnapshot() ([]byte, error) {
return nil, stacktrace.NewErrorWithCode(dsserr.NotImplemented, "not implemented yet")
return r.memStore.GetSnapshot()
}

func (r *repo) RestoreFromSnapshot([]byte) error {
return stacktrace.NewErrorWithCode(dsserr.NotImplemented, "not implemented yet")
func (r *repo) RestoreFromSnapshot(data []byte) error {
return r.memStore.RestoreFromSnapshot(data)
}

func (r *repo) Apply(_ context.Context, _ consensus.Proposal) (any, error) {
return nil, stacktrace.NewErrorWithCode(dsserr.NotImplemented, "not implemented yet")
func (r *repo) Apply(ctx context.Context, proposal consensus.Proposal) (any, error) {
switch proposal.RequestType {

default:
handler, ok := actions.Registry[string(proposal.RequestType)]

@mickmis mickmis Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update registry map key type to use RequestType

@MariemBaccari MariemBaccari Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the registry is defined outside of both raftstore and sqlstore and is used by both, it feels odd leaking consensus.RequestType into it. What do you think ?

@mickmis mickmis Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. That actually raises the question of whether there is (and will always be) a 1-1 mapping between DSS operations and raft messages? But it looks like those are different although overlapping sets. So LGTM.

if !ok {
return nil, stacktrace.NewError("unrecognized request type: %s", proposal.RequestType)
}

request, err := handler.Decode(proposal.Value)
if err != nil {
return nil, stacktrace.Propagate(err, "failed to decode %s payload", proposal.RequestType)
}

return handler.Execute(ctx, r.memRepo, request)
}
}
Loading