[raftstore] Embed memstore and use checkpoint - #1669
Open
MariemBaccari wants to merge 19 commits into
Open
Conversation
MariemBaccari
marked this pull request as ready for review
August 28, 2026 11:41
This was referenced Aug 28, 2026
This was referenced Aug 28, 2026
MariemBaccari
force-pushed
the
use_checkpoint
branch
from
August 31, 2026 09:42
7ad2d80 to
5fe0a16
Compare
mickmis
approved these changes
Aug 31, 2026
| proposalCtx = locality.NewContext(proposalCtx, commit.Prop.Locality) | ||
| s.raftRepo.Checkpoint() | ||
| result, err := s.raftRepo.Apply(proposalCtx, commit.Prop) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Some logging advising of the restore could be handy here.
|
|
||
| // Restore reverts the state to the last Checkpoint, called when Apply returns an error so a | ||
| // failed proposal cannot leave a partial mutation in place. | ||
| Restore() |
Contributor
There was a problem hiding this comment.
In the end shouldn't RaftRepo embed the MemRepo interface? It just has Apply in addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PR: #1627 -> #1642 -> #1643 -> #1644 -> #1645 -> #1646 -> #1649 -> #1650 -> #1651 -> #1653 -> #1654 -> #1656 -> #1657 -> #1655 -> #1666 -> #1667 -> #1668 -> #1669
This PR adds the use of the memstore checkpoint to ensure raft operations are atomic and embeds the memstore directly to simplify the raftstore.