Skip to content

Add Kasboeking and Dagboek functionality - #18

Open
ikulis wants to merge 13 commits into
iwd-nl:masterfrom
storekeeper-company:add-kasboeking
Open

ikulis wants to merge 13 commits into
iwd-nl:masterfrom
storekeeper-company:add-kasboeking

Conversation

@ikulis

@ikulis ikulis commented Sep 12, 2021

Copy link
Copy Markdown

Dagboek [findAll]
Kasboeking [find/add/update/delete]

Made mode specific class SnelstartPHP\Model\V2\Koopboeking which is extended by Verkoopboeking and Inkoopboeking, so I can extend the base SnelstartPHP\Model\V2\Boeking.

@manuelderuiter

Copy link
Copy Markdown
Contributor

Thanks for your contribution! It looks great so far. Haven't had the opportunity to test it yet.

@arwinvdv

arwinvdv commented Nov 16, 2021

Copy link
Copy Markdown

@ikulis to add a Kasboeking, the inkoopboekingBoekingsRegels and verkoopboekingBoekingsRegels params has to have an boekingId. I fixed it in 2119add

edit: typo

@ikulis

ikulis commented Nov 16, 2021

Copy link
Copy Markdown
Author

@arwinvdv Indeed overlooked it, I was testing with the grootboekBoekingsRegels. Thank you for testing that one. Are you able to attach to the pr or should I do it?

@arwinvdv

Copy link
Copy Markdown

I'm not that experienced with pull requests so it would be nice if you can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants