Add profile checkbox to enable/disable tooltips (rebase of #3446)#3807
Open
mcfnord wants to merge 3 commits into
Open
Add profile checkbox to enable/disable tooltips (rebase of #3446)#3807mcfnord wants to merge 3 commits into
mcfnord wants to merge 3 commits into
Conversation
Since jamulussoftware#3446 was written, main gained its own eventFilter override in CClientSettingsDlg (MIDI device list refresh on dropdown click), which collided with the one this branch adds. Fold the ToolTip suppression check into that filter and drop the duplicate declaration/definition. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This supersedes (and is a rebase of) #3446 by @softins, which was approved by @ann0see but has since gone stale against
main. It adds a "Show tool tips" checkbox to the Settings dialog; the setting is stored in the.inifile, and per-dialog event filters consumeQEvent::ToolTipwhen tooltips are disabled.softins' two commits are preserved unchanged (authorship intact). One adaptation commit on top resolves the drift since the PR was written:
mainnow has its ownCClientSettingsDlg::eventFilteroverride (MIDI device-list refresh, from the MIDI settings work), so the tooltip suppression check is folded into that existing filter instead of adding a duplicate.CHANGELOG: Add profile checkbox to enable/disable tooltips
Context: Fixes an issue?
Supersedes #3446. Also unblocks #3252, whose approval was conditioned on this toggle existing.
Does this change need documentation? What needs to be documented and how?
Possibly a short note on the website settings docs for the new checkbox.
Status of this Pull Request
Ready for review. Builds clean with Qt 5.15 on Linux; clang-format-14 clean; headless SIGTERM smoke test passes. The functional behavior was already tested by @ann0see on Windows in the original PR ("On windows it works as expected").
🤖 Generated with Claude Code