Check for half open interval in MathUtils::InRange#3812
Merged
Conversation
Fix its usage in server.cpp
5 tasks
softins
reviewed
Jul 20, 2026
Member
|
Of course, there is now an interdependency between this and #3810 |
Co-authored-by: Tony Mountifield <tony@mountifield.org>
pljones
approved these changes
Jul 21, 2026
Collaborator
|
OK, this can go to main then needs to go to release/3_12 - but both this and #3810 (two commits) on one PR to land there. |
pljones
added
the
backport_required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix its usage in server.cpp
Short description of changes
As requested in #3810 make the interval half open for MathsUtils::InRange
CHANGELOG:
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Approval
Checklist