[JENKINS-47803 && JENKINS-7009] Remove working copy if external is broken - #247
Open
PhilippHomann wants to merge 2 commits into
Open
[JENKINS-47803 && JENKINS-7009] Remove working copy if external is broken#247PhilippHomann wants to merge 2 commits into
PhilippHomann wants to merge 2 commits into
Conversation
Author
|
Anyone? |
Member
|
I'm not a maintainer. The only reason I show up in the history is because I staged security fixes. |
Member
|
I also do not pretend to maintain this plugin. Not sure if anyone does. |
PhilippHomann
force-pushed
the
removeOnExternalFailure
branch
from
September 9, 2026 08:07
814a5e8 to
b04c6c2
Compare
MarkEWaite
removed their request for review
September 9, 2026 11:58
Eccenux
reviewed
Sep 9, 2026
|
|
||
| @Issue("JENKINS-47803") | ||
| @Test | ||
| public void lockedExternal() throws Exception { |
Contributor
There was a problem hiding this comment.
should have a comment on the setup phase of the test – what is being setup and why
| @Test | ||
| public void ensureCancelOnExternalsFail() throws Exception { | ||
| Proc p = runSvnServe(getClass().getResource("JENKINS-777.zip")); | ||
|
|
Contributor
There was a problem hiding this comment.
Same as above. should have a comment on the setup phase of the test – what is being setup and why
| } | ||
| } | ||
|
|
||
| void lockWorkspace(String dbFile, String pathToLock) throws Exception { |
Contributor
There was a problem hiding this comment.
That is an interesting way to emulate a lock. Is this documented somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently checkout will silently ignores an external failure due to locked working copy.
So build continues without one recognizing that the result is build using an old revision.
With this fix the update will behave like the non-external checkout: delete working copy and start with a fresh one.