[bridge] fix nil pointer when global.digests is unset - #2519
Merged
vitaliil-jfrog merged 2 commits intoSep 2, 2026
Merged
vitaliil-jfrog merged 2 commits into
vitaliil-jfrog merged 2 commits into
Conversation
bridge's image helpers dereference .Values.global.digests.<x> without a nil
guard. When bridge is used as a subchart of jfrog-platform alongside catalog,
worker or wingman — whose values define a global block without a digests key —
the coalesced global has no digests, and rendering fails:
Error: jfrog-platform/charts/bridge/templates/_helpers.tpl:44:14
executing "router.image" at <.Values.global.digests.router>:
nil pointer evaluating interface {}.router
bridge is the only chart referencing global.digests in its helpers, so the
fix is local: use the nil-safe (.Values.global.digests).<x> form, which holds
regardless of which sibling subcharts are enabled and leaves behaviour
unchanged when digests are supplied.
Applied to all five image helpers (bridge, router, initContainers,
observability, filebeat).
This was referenced Aug 29, 2026
vitaliil-jfrog
changed the base branch from
master
to
bridge-101.262.58-20260902-182903
September 2, 2026 13:00
vitaliil-jfrog
merged commit Sep 2, 2026
c8575cb
into
jfrog:bridge-101.262.58-20260902-182903
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What this PR does / why we need it:
stable/bridge/templates/_helpers.tpldereferences.Values.global.digests.<x>with no nil guard. Whenbridgeruns as a subchart ofjfrog-platformalongsidecatalog,workerorwingman— whose values define aglobalblock with nodigestskey — the coalescedglobalhas nodigests, and rendering fails:bridgeis the only chart referencingglobal.digestsin its helpers, so the fix is local: the nil-safe(.Values.global.digests).<x>form. It holds regardless of which sibling subcharts are enabled, and behaviour is unchanged when digests are supplied. Applied to all five image helpers —bridge,router,initContainers,observability,filebeat.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2517Special notes for your reviewer:
Verified by A/B against this branch, with a control that passes both ways so the harness itself is validated:
digests: {})--set global.digests=null)_helpers.tpl:55:14No README change — this adds no values.