Repository navigation
Upgrade actions/checkout to v7 and let fork pull requests be checked out - #193
Draft
Jordanh1996 wants to merge 2 commits into
Draft
Jordanh1996 wants to merge 2 commits into
Jordanh1996 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
These workflows use actions/checkout v3 and v4. Their
pull_request_targetjobs can't check out pull requests opened from a fork:actions/checkoutrefuses withRefusing to check out fork pull request code from a 'pull_request_target' workflow.Description
Every
actions/checkoutstep in.github/workflowsnow uses v7. Thepull_request_targetcheckouts of the pull request head getallow-unsafe-pr-checkout: truein the Frogbot and test workflows, which are already gated by thefrogbotenvironment approval and the "safe to test" label, andpersist-credentials: falseso the token isn't left on disk for pull request code. Same setup as jfrog-idea-plugin, jfrog-vscode-extension and jfrog-cli-security.Tests
CI on this PR. Since
pull_request_targetruns the base branch's workflow, the fork fix takes effect after merge.🤖 Generated with Claude Code