Skip to content

Boolean Values Are Not Processed Correctly #62

Description

@squat

The golang docsonnet loader expects booleans to have a type string of boolean whereas the doc-util library injects type strings of bool. This causes all rendering for booleans to fail unless you eschew usage of d.T.boolean and manually pass 'boolean' when declaring a d.val.

Lots of libraries are already annotated with docsonnet using d.T.boolean but who knows how many people are using the workaround of explicitly passing 'boolean' to the value constructor. In order to break as few people as possible, we should modify https://github.com/jsonnet-libs/docsonnet/blob/master/doc-util/main.libsonnet#L223 so that it evaluates to 'boolean'.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions