Repository navigation
fix(build): compile the cmd package, not just main.go - #198
Merged
Merged
Conversation
The install/release build scripts compiled a single file (`cmd/$b/main.go`), which broke after main.go was split into sibling files (run.go/flags.go/ config.go): `make reinstall` failed with `undefined: run`, `undefined: setupFlags`, etc. Build the whole package (`./cmd/$b`) instead, matching how the Homebrew formula already builds (`./cmd/chatgpt`). Fixes install.sh (make reinstall/ install), binaries.sh (the release path — would also have failed), and install.ps1. CI didn't catch this because `go test ./...` builds packages; only the single-file install/release path was affected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make reinstall(andmake install) broke aftermain.gowas split into sibling files (run.go/flags.go/config.goin #195):The install/release scripts compiled a single file (
go build ... -a cmd/$b/main.go), so oncemain.go's functions moved into sibling files in the same package, that build no longer sees them.Fix
Build the whole package (
./cmd/$b) instead — matching how the Homebrew formula already builds (./cmd/chatgpt). Touchesinstall.sh(make reinstall/install),binaries.sh(the release path — would also have failed), andinstall.ps1.Why CI missed it
make unit/make integrationusego test ./..., which builds packages, so they stayed green. Only the single-file install/release path was affected. Verifiedmake reinstallbuilds + runs (--versionOK) and a cross-compile target builds via the package form.