fix: parse WebVTT cues with settings - #243
Open
itboy87 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
line/verticalsettingsPreviously, the parser required the first timing line to fully match a timestamp-only regex. Valid lines such as:
00:00:01.000 --> 00:00:03.000 line:0were skipped, resulting in an empty cue list.
Testing
./gradlew :mediaplayer:jvmTest --tests 'io.github.kdroidfilter.composemediaplayer.subtitle.WebVttParserTest'./gradlew :mediaplayer:ktlintCheckReproduction samples
These public WebVTT files reproduce the issue:
They contain valid cue settings such as
line:0,line:-1, andvertical:rl. Previously, the parser skipped the first timing line because it required the timestamp-only pattern to match the entire line.