Repository navigation
Return the readable firmware version from device_info - #174
Open
erwindouna wants to merge 1 commit into
Open
erwindouna wants to merge 1 commit into
erwindouna wants to merge 1 commit into
Conversation
device_info() returned the raw firmware integer (e.g. "67643140") since e21bb6c dropped the version_int_to_string() call; restore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device_info()has returned the raw firmware integer assw_version(for example"67643140"instead of"4.8.39.R") since e21bb6c dropped theversion_int_to_string()call. Home Assistant shows that raw number as the device's firmware.This restores the conversion.
test_device_infonow sends a real firmware value (from an STP5.0-3SE-40 on 4.08.39.R) and fails without the fix.