feat(windows): update cef4delphi 146 - #16310
Draft
rc-swag wants to merge 3 commits into
Draft
Conversation
No build scripts and projects have been updated in this commit
…cef4delphi-146-0-12
# Keyman Conventional Commit suggestions:
#
# - Link to a Sentry issue with git trailer:
# Fixes: _MODULE_-_ID_
# - Give credit to co-authors:
# Co-authored-by: _Name_ <_email_>
# - Use imperative, present tense ('attach' not 'attaches', 'attached' etc)
# - Don't include a period at the end of the title
# - Always include a blank line before trailers
# - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
Changes to support the CEF4Delphi update to CEF 146. These include GlobalCEFApp.DoNotDeElevate = True CEF now preferes to always run unelevated. We already have a seperate issue to not load the CEF for kmshell command line instances. We should be able to then honor not having any elevated CEF instances. OnWidgetCompMsg has been removed the focus verification will now be via GotFocus
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined |
rc-swag
commented
Aug 7, 2026
| @@ -847,7 +847,6 @@ th | |||
|
|
|||
| .support_title | |||
| { | |||
| background: url('keyman-title.png') 96px 13px no-repeat; | |||
Contributor
Author
There was a problem hiding this comment.
When looking at the Dev Tools for errors this dead reference was found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: 15896
Changes include GlobalCEFApp.DoNotDeElevate = True
CEF now preferes to always run unelevated. We already have
a seperate issue to not load the CEF for kmshell command
line instances. Here its #11901. We should be able to then honor not
having any elevated CEF instances.
OnWidgetCompMsg has been removed the focus verification will
now be via GotFocus