Repository navigation
fix(mcp): don't route every "current"/"supported" question to release… - #304
Open
shrxyas-246 wants to merge 1 commit into
Open
shrxyas-246 wants to merge 1 commit into
shrxyas-246 wants to merge 1 commit into
Conversation
… notes The router sent any docs query containing "current" or "supported" down the latest-release path: release notes only, sorted by date, no reranker. How-to questions like "Is dsl.ParallelFor supported in KFP v2?" or "How do I get the current run ID inside a KFP component?" got release notes back instead of the docs pages that answer them. "latest", "newest" and "most recent" still always count. "current" and "supported" now only count within three words of "version" or "release", so "current version of KFP", "supported Kubernetes versions" and "Which release is current?" still search release notes. The check is a small helper next to the existing regex rather than a change to the regex itself, so it doesn't touch the lines kubeflow#290 changes. Fixes kubeflow#289 Signed-off-by: Shreyas <shreyassrini2007@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
Bot
requested review from
chasecadet and
franciscojavierarceo
November 20, 2026 10:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
cc @kmr-rohit, as we discussed at the Nov 15 community meetup.
What was wrong
pick_search_plansends a question down the "latest release" path if it containscurrentorsupported. That path only searches release notes, sorts them by date and skips the reranker. So normal how-to questions that just happen to use one of those words get release notes back instead of the docs page with the answer. Two of them are already in the eval set (fid-parallelfor-v2anddbg-external-mysql).What I changed
latest,newestandmost recentstill always mean the latest release.currentandsupportedonly count when they're within 3 words ofversionorrelease, in either order. "current version of KFP", "supported Kubernetes versions" and "Which release is current?" still go to release notes, "the current run ID" doesn't.asks_for_latest_release(), next to the existing regex. I didn't edit the regex itself because feat(rag): recurring ingest, community-distribution docs, and latest-query retrieval #290 changes that same line, so the two PRs don't touch the same lines and can be merged in either order. The helper only filters outcurrent/supported, so anything else the regex matches still counts, including the "new / next / last release" phrasing feat(rag): recurring ingest, community-distribution docs, and latest-query retrieval #290 adds.docs/RAG_V4_ARCHITECTURE.mdto match.tests/test_intent_router_temporal.py: 6 release questions that must stay temporal and 6 how-to questions that must not, including the keyword forms the system prompt asks the model to send.Results
Before (main): all four how-to questions go to release notes and the 6 how-to test cases fail.
After (this PR): the how-to questions get normal docs search and the release questions are unchanged. 12 passed, full suite 172 passed, 69 skipped (the 160 existing tests plus the 12 new ones).
On top of #290: the same change applies cleanly to #290's branch. 12 passed, full suite 202 passed, 69 skipped.