test(util): add unit tests for CreateValidMetricNameLabel

[magic-peach]

Purpose of this PR

pkg/util/metrics.go's CreateValidMetricNameLabel (dash-to-underscore metric label sanitizing) had no test file at all.

Proposed changes:

• Add pkg/util/metrics_test.go covering dashes being replaced in both the prefix and the name, and the concatenation being returned unchanged when there are no dashes.

Change Category

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that could affect existing functionality)
• Documentation update

Rationale

None of the categories above quite fit: this is a test-only addition, no production code changed.

Checklist

• I have conducted a self-review of my own code.
• I have updated documentation accordingly.
• I have added tests that prove my changes are effective or that my feature works.
• Existing unit tests pass locally with my changes.

Additional Notes

Ran go test ./pkg/util/...: all specs pass. go vet ./pkg/util/... clean.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

🎉 Welcome to the Kubeflow Spark Operator! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

• If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
• Our team will review your PR soon!

Join the community:

• Slack: Join our #kubeflow-spark-on-kubernetes Slack channel.

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

[tariq-hasan]

Hi @magic-peach! Thanks for the PR. Overall lgtm. I have one suggestion to add some more cases.

[tariq-hasan]

/retitle test(util): add unit tests for CreateValidMetricNameLabel

[tariq-hasan]

/ok-to-test
/retest

[magic-peach]

Expanded to a DescribeTable with the suggested cases, including the empty-prefix and consecutive-dash entries. Pushed.

[RobuRishabh]

/lgtm
Thanks

[nabuskey]

/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nabuskey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [nabuskey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment