Skip to content

Update dependencies and devcontainer SDKs - #1945

Open
brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:deps/combined-updates-1932-1933-1934-1937
Open

brendandburns wants to merge 1 commit into
kubernetes-client:masterfrom
brendandburns:deps/combined-updates-1932-1933-1934-1937

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

Summary

Validation

  • dotnet build src/KubernetesClient/KubernetesClient.csproj --configuration Release --framework net8.0 --no-restore --target:Rebuild
  • full traversal build progressed past all Scriban and generated-source failures with no errors before the local execution limit cancelled it

Copilot AI balanced review requested due to automatic review settings October 14, 2026 04:12
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from tg123 October 14, 2026 04:12
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Multiple dependency upgrades affect source generation and AOT behavior without a completed full traversal build.

0 open findings

What changed in this PR

Updates dependencies, generator compatibility, and the development container for .NET 8–10.

Changes:

  • Upgrades four dependencies and adds PolySharp.
  • Adapts embedded Scriban generation to 7.5 defaults.
  • Adds a multi-SDK devcontainer.
File Description
Directory.Packages.props Updates dependency versions and adds PolySharp.
src/​LibKubernetesGenerator/​LibKubernetesGenerator.target Configures PolySharp for embedded Scriban sources.
src/​LibKubernetesGenerator/​GeneratorExecutionContextExt.cs Disables limits for trusted generator templates.
.devcontainer/​Dockerfile Provides .NET 8, 9, and 10 SDKs.
.devcontainer/​devcontainer.json Builds the new Dockerfile-based container.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants