Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
kubernetes-prow
Bot
added
the
size/XXL
07cea7d to
a268d40
Compare
|
/assign @serathius okay let's iterate this. |
| deliberate: Grafana has no duration axis mode, so an axis labelled `00:00`, `00:30`, | ||
| `01:00` reads as elapsed time for free. | ||
|
|
||
| The offset is computed once per run, from the earliest `minTime` across its Prometheus |
There was a problem hiding this comment.
Nit: Can we compute minTime based on Cluster loader steps?
| environment: | ||
| - GF_AUTH_ANONYMOUS_ENABLED=true | ||
| - GF_AUTH_ANONYMOUS_ORG_ROLE=Admin | ||
| - GF_NEWS_NEWS_FEED_ENABLED=false |
|
|
||
| const twoHoursMS = int64(2 * 60 * 60 * 1000) | ||
|
|
||
| // runSpanStepMS is the cadence used for values that hold for a whole run, such as |
There was a problem hiding this comment.
Not that I have high requirements for vibecoded project, but I cannot understand this comment at all.
|
Overall I like the direction of automatically aligning runs on timeline, however I'm worried that rewriting prometheus snapshots adds complexity and performance implication. I used thanos to avoid rewriting blocks for exactly this reason. My ask is whether we can make this change semi reviewable so we can discuss prometheus setup and code architecture. Would splitting this PR into steps would be useful or we should merge without code review? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jefftree The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6aa2186 to
25b1b82
Compare
|
@Jefftree: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Basically allows us to loosely compare two runs in the same dashboard and we don't need to hunt for the time as we align every run to start at 2000/1/1 0:00 UTC.