Respect q=0 in gzip content negotiation#3028
Open
freakes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix gzip middleware to respect
q=0values in theAccept-Encodingheader.Problem
According to RFC 9110, an encoding with
q=0is explicitly unacceptable. The current implementation does not respect this quality value and may enable gzip even when the client sends:Accept-Encoding: gzip;q=0Solution
Update the gzip negotiation logic to honor
q=0quality values and skip gzip when it is explicitly marked as unacceptable.Testing
Accept-Encoding: gzip;q=0go test ./middleware