Repository navigation
feat: size HTML images from their width and height attributes - #24
Merged
Merged
Conversation
Documents that embed pictures with `<img>` usually say how big they want them, and this README is one of them: its GIFs carry a width and its sponsor badges a height. Ignoring both meant every one of them came out at the full text width. A CSS pixel is a 96th of an inch, so an attribute converts to a real length instead of a guess about how wide the page is. The fit still applies on top, so a number larger than the text block shrinks to it rather than running off the page, and a percentage is ignored because fitting the text block is what the default already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents that embed pictures with
<img>usually say how big they want them, and this README is one of them: its GIFs carry a width and its sponsor badges a height. Ignoring both meant every one of them came out at the full text width.A CSS pixel is a 96th of an inch, so an attribute converts to a real length instead of a guess about how wide the page is. The fit still applies on top, so a number larger than the text block shrinks to it rather than running off the page, and a percentage is ignored because fitting the text block is what the default already does.